From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4bgs-0001bg-Ig for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:27:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4bgn-0000IB-W0 for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:27:18 -0500 Received: from mail-pz0-f46.google.com ([209.85.210.46]:40490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4bgn-0000Hm-PB for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:27:13 -0500 Received: by dajr28 with SMTP id r28so6683686daj.33 for ; Mon, 05 Mar 2012 09:27:11 -0800 (PST) Message-ID: <4F54F76B.70403@codemonkey.ws> Date: Mon, 05 Mar 2012 11:27:07 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1330956981-5001-1-git-send-email-alevy@redhat.com> <4F54CEA2.10808@codemonkey.ws> <4F54F5F8.70105@redhat.com> In-Reply-To: <4F54F5F8.70105@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: lcapitulino@redhat.com, Alon Levy , kraxel@redhat.com, qemu-devel@nongnu.org On 03/05/2012 11:20 AM, Avi Kivity wrote: > On 03/05/2012 04:33 PM, Anthony Liguori wrote: >> >> >> async in QEMU doesn't mean "generate a QMP event when you're done". >> It should mean execute this closure when you finish (function pointer >> + opaque). >> >> The QMP event should be dispatched from the closure such that the >> screendump code doesn't have to have a direct dependency on QMP. >> > > What about using the parallel execution facility of qmp? It's silly to > duplicate every command X with X-async and X-COMPLETED. We need to switch over to QAPI to get there. We're pretty close to being there. Luiz, about how long do you think before we get there? Regards, Anthony Liguori >