From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4biw-000340-9o for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:29:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4biq-0000q2-28 for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:29:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4bip-0000oR-QG for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:29:19 -0500 Message-ID: <4F54F7EA.2010705@redhat.com> Date: Mon, 05 Mar 2012 19:29:14 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1330956981-5001-1-git-send-email-alevy@redhat.com> <4F54CEA2.10808@codemonkey.ws> <4F54F5F8.70105@redhat.com> <4F54F76B.70403@codemonkey.ws> In-Reply-To: <4F54F76B.70403@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: lcapitulino@redhat.com, Alon Levy , kraxel@redhat.com, qemu-devel@nongnu.org On 03/05/2012 07:27 PM, Anthony Liguori wrote: > On 03/05/2012 11:20 AM, Avi Kivity wrote: >> On 03/05/2012 04:33 PM, Anthony Liguori wrote: >>> >>> >>> async in QEMU doesn't mean "generate a QMP event when you're done". >>> It should mean execute this closure when you finish (function pointer >>> + opaque). >>> >>> The QMP event should be dispatched from the closure such that the >>> screendump code doesn't have to have a direct dependency on QMP. >>> >> >> What about using the parallel execution facility of qmp? It's silly to >> duplicate every command X with X-async and X-COMPLETED. > > We need to switch over to QAPI to get there. Just an implementation detail, yes? No spec/protocol changes? > We're pretty close to being there. Luiz, about how long do you > think before we get there? It's a pity to add new commands along the way. -- error compiling committee.c: too many arguments to function