From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51444)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1S4d6j-0004sT-9P
	for qemu-devel@nongnu.org; Mon, 05 Mar 2012 13:58:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1S4d6a-00050t-Mb
	for qemu-devel@nongnu.org; Mon, 05 Mar 2012 13:58:04 -0500
Received: from cantor2.suse.de ([195.135.220.15]:41621 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1S4d6a-00050h-G3
	for qemu-devel@nongnu.org; Mon, 05 Mar 2012 13:57:56 -0500
Message-ID: <4F550CB2.4040201@suse.de>
Date: Mon, 05 Mar 2012 19:57:54 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1330727407-24014-1-git-send-email-sw@weilnetz.de>
	<1330727407-24014-6-git-send-email-sw@weilnetz.de>
In-Reply-To: <1330727407-24014-6-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 5/6] cache-utils: Change data type of
	parameters for flush_icache_range
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel@nongnu.org

On 03/02/2012 11:30 PM, Stefan Weil wrote:
> The TCG targets i386 and tci needed a change of the function
> prototype for w64.
>
> This change is currently not needed here, but it can be applied
> to avoid code differences.
>
> Cc: Alexander Graf<agraf@suse.de>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
> ---
>   cache-utils.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cache-utils.h b/cache-utils.h
> index 0b65907..04a6e2e 100644
> --- a/cache-utils.h
> +++ b/cache-utils.h
> @@ -12,7 +12,7 @@ extern struct qemu_cache_conf qemu_cache_conf;
>   void qemu_cache_utils_init(char **envp);
>
>   /* mildly adjusted code from tcg-dyngen.c */
> -static inline void flush_icache_range(unsigned long start, unsigned lo=
ng stop)
> +static inline void flush_icache_range(uintptr_t start, uintptr_t stop)

Ugh, this causes compilation breakage:

CC cache-utils.o
In file included from cache-utils.c:1:
cache-utils.h:15: error: expected =91)=92 before =91start=92
make: *** [cache-utils.o] Error 1

because cache-utils.c doesn't include anything that would define=20
uintptr_t. Any idea how to fix this?


Alex