From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4dDA-0000tg-7o for qemu-devel@nongnu.org; Mon, 05 Mar 2012 14:04:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4dD8-0006n1-78 for qemu-devel@nongnu.org; Mon, 05 Mar 2012 14:04:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4dD7-0006mE-Uh for qemu-devel@nongnu.org; Mon, 05 Mar 2012 14:04:42 -0500 Message-ID: <4F550E46.6040806@redhat.com> Date: Mon, 05 Mar 2012 12:04:38 -0700 From: Eric Blake MIME-Version: 1.0 References: <1330968842-24635-1-git-send-email-pbonzini@redhat.com> <1330968842-24635-8-git-send-email-pbonzini@redhat.com> In-Reply-To: <1330968842-24635-8-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig27028B99974EF3F415215015" Subject: Re: [Qemu-devel] [PATCH v3 7/8] add mirroring to transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, fsimonce@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig27028B99974EF3F415215015 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/05/2012 10:34 AM, Paolo Bonzini wrote: > With it comes a new image creation mode, "no-backing-file", that can > be used to stream an image so that the destination does not need the > original image's backing file(s). >=20 > Both bdrv_append and blkmirror will set the backing_hd on the target, > even if the image is created without one, so that both streaming and > copy-on-write work properly (at least with qcow2 or qed, not raw). >=20 > Streaming mode works with the following gotchas: >=20 > - streaming will rewrite every bit of the source image; >=20 > - zero writes are not supported by the blkmirror driver, hence both > the source and the destination image will grow to full size. >=20 > @@ -1159,7 +1175,8 @@ > ## > { 'union': 'BlockdevAction', > 'data': { > - 'blockdev-snapshot-sync': 'BlockdevSnapshot' > + 'blockdev-snapshot-sync': 'BlockdevSnapshot', Minor nit - should we rebase this trailing comma earlier in the series, to make it obvious that BlockdevAction will grow and for less churn in this patch? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig27028B99974EF3F415215015 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPVQ5GAAoJEKeha0olJ0Nq7zsH/Rh6RGgjM8NT/B6rzpik5/CM I4yHY2yOTVRV4RE4+byrSyaDspGNMde/RYztDTJfKgmcEMwjfn9rnze8VFGiV2Yd 9Ln+YWgkOm+SWWOovSRkQePrmQ07Fi+vGywxBFrC5QOTCvDV3/a2Vr8OM9UnX3X1 +DvU6LIeTwMj/lgxoKNw70oZBx5FpW4PD3tOYr8LO+1/Z+rvqMyP2rACa3phoB75 SNRNiLyjEM2lPNHjSZMchNZJ/tPOL/hHVVzbzvhbHyH5HwOoiVTOyucMzGAsMKRf NqzAjZhOsAOpnxpjrTrrjOOQvPLA7/pgm40zM1EPo8tcbcQxQcMXm+5NZsnToPc= =h7Q0 -----END PGP SIGNATURE----- --------------enig27028B99974EF3F415215015--