From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4fGw-0004Jt-BC for qemu-devel@nongnu.org; Mon, 05 Mar 2012 16:16:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4fGu-0008O0-MB for qemu-devel@nongnu.org; Mon, 05 Mar 2012 16:16:45 -0500 Received: from mail-ey0-f173.google.com ([209.85.215.173]:58728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4fGu-0008Na-DL for qemu-devel@nongnu.org; Mon, 05 Mar 2012 16:16:44 -0500 Received: by eaaf11 with SMTP id f11so940169eaa.4 for ; Mon, 05 Mar 2012 13:16:42 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F552D38.2050003@redhat.com> Date: Mon, 05 Mar 2012 22:16:40 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1330968842-24635-1-git-send-email-pbonzini@redhat.com> <1330968842-24635-6-git-send-email-pbonzini@redhat.com> <4F550C34.90005@redhat.com> <4F5517A7.90207@redhat.com> In-Reply-To: <4F5517A7.90207@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, fsimonce@redhat.com, Eric Blake Il 05/03/2012 20:44, Paolo Bonzini ha scritto: > Il 05/03/2012 19:55, Eric Blake ha scritto: >> Right now, libvirt has an API virDomainSnapshotCreateXML with a flag >> VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT, which should map to this new mode >> operand. Am I guaranteed that if I pass a 'mode' argument of 'existing' >> to an older qemu that lacked mode, I will get a sane error? If so, then >> this rewrite looks fine from libvirt's point of view. > > Not sure... Luiz? Well, you could always use the transaction command if the flag is there. That command will have it always. Paolo