From: Paolo Bonzini <pbonzini@redhat.com>
To: Mark Wu <wudxw@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com,
qemu-devel@nongnu.org, lcapitulino@redhat.com,
fsimonce@redhat.com, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions
Date: Tue, 06 Mar 2012 09:14:23 +0100 [thread overview]
Message-ID: <4F55C75F.90508@redhat.com> (raw)
In-Reply-To: <4F55B9D4.7070106@linux.vnet.ibm.com>
Il 06/03/2012 08:16, Mark Wu ha scritto:
> It seems we need a name for the union to reference its member.
What version is your compiler?
> So I
> modified the scripts as the following patch. I also updated blockdev.c
> accordingly. After that I can compile it without error. Actually, I
> don't know why we need introduce a union for BlockdevAction. Can we just
> use a void pointer like "void *action_param" to replace the union? Or
> can we change the field ."snapshot_file to "target" too? Then they can
> share the same action parameter structure.
No, the struct must match the existing blockdev-snapshot-sync command.
Paolo
next prev parent reply other threads:[~2012-03-06 8:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 17:33 [Qemu-devel] [PATCH v3 0/8] Mirrored block writes Paolo Bonzini
2012-03-05 17:33 ` [Qemu-devel] [PATCH v3 1/8] fix format name for backing file Paolo Bonzini
2012-03-05 17:33 ` [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions Paolo Bonzini
2012-03-06 7:16 ` Mark Wu
2012-03-06 8:14 ` Paolo Bonzini [this message]
2012-03-06 8:19 ` Mark Wu
2012-03-06 8:31 ` Paolo Bonzini
2012-03-06 9:41 ` Mark Wu
2012-03-06 10:00 ` Paolo Bonzini
2012-03-05 17:33 ` [Qemu-devel] [PATCH v3 3/8] rename blockdev-group-snapshot-sync Paolo Bonzini
2012-03-05 17:33 ` [Qemu-devel] [PATCH v3 4/8] add mode field to blockdev-snapshot-sync transaction item Paolo Bonzini
2012-03-05 18:45 ` Eric Blake
2012-03-05 17:33 ` [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions Paolo Bonzini
2012-03-05 18:55 ` Eric Blake
2012-03-05 19:44 ` Paolo Bonzini
2012-03-05 21:16 ` Paolo Bonzini
2012-03-06 11:30 ` Luiz Capitulino
2012-03-05 17:34 ` [Qemu-devel] [PATCH v3 6/8] Add blkmirror block driver Paolo Bonzini
2012-03-05 17:34 ` [Qemu-devel] [PATCH v3 7/8] add mirroring to transaction Paolo Bonzini
2012-03-05 19:04 ` Eric Blake
2012-03-05 17:34 ` [Qemu-devel] [PATCH v3 8/8] add drive-mirror command and HMP equivalent Paolo Bonzini
2012-03-06 8:02 ` [Qemu-devel] [PATCH v3 9/8] Add the drive-reopen command Paolo Bonzini
2012-03-06 8:52 ` [Qemu-devel] [PATCH v3 10/8] use QSIMPLEQ_FOREACH_SAFE when freeing list elements Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F55C75F.90508@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=fsimonce@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wudxw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).