From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4pXZ-0003Vp-M9 for qemu-devel@nongnu.org; Tue, 06 Mar 2012 03:14:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4pXT-0002py-HM for qemu-devel@nongnu.org; Tue, 06 Mar 2012 03:14:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4pXT-0002po-8r for qemu-devel@nongnu.org; Tue, 06 Mar 2012 03:14:31 -0500 Message-ID: <4F55C75F.90508@redhat.com> Date: Tue, 06 Mar 2012 09:14:23 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1330968842-24635-1-git-send-email-pbonzini@redhat.com> <1330968842-24635-3-git-send-email-pbonzini@redhat.com> <4F55B9D4.7070106@linux.vnet.ibm.com> In-Reply-To: <4F55B9D4.7070106@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Wu Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, fsimonce@redhat.com, eblake@redhat.com Il 06/03/2012 08:16, Mark Wu ha scritto: > It seems we need a name for the union to reference its member. What version is your compiler? > So I > modified the scripts as the following patch. I also updated blockdev.c > accordingly. After that I can compile it without error. Actually, I > don't know why we need introduce a union for BlockdevAction. Can we just > use a void pointer like "void *action_param" to replace the union? Or > can we change the field ."snapshot_file to "target" too? Then they can > share the same action parameter structure. No, the struct must match the existing blockdev-snapshot-sync command. Paolo