From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: handle -EBUSY in bdrv_commit_all()
Date: Tue, 06 Mar 2012 11:01:18 +0100 [thread overview]
Message-ID: <4F55E06E.60404@redhat.com> (raw)
In-Reply-To: <1330971011-31646-1-git-send-email-stefanha@linux.vnet.ibm.com>
Am 05.03.2012 19:10, schrieb Stefan Hajnoczi:
> Monitor operations that manipulate image files must not execute while a
> background job (like image streaming) is in progress. This prevents
> corruptions from happening when two pieces of code are manipulating the
> image file without knowledge of each other.
>
> The monitor "commit" command raises QERR_DEVICE_IN_USE when
> bdrv_commit() returns -EBUSY but "commit all" has no error handling.
> This is easy to fix, although note that we do not deliver a detailed
> error about which device was busy in the "commit all" case.
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2012-03-06 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 18:10 [Qemu-devel] [PATCH] block: handle -EBUSY in bdrv_commit_all() Stefan Hajnoczi
2012-03-06 10:01 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F55E06E.60404@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).