From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4rbL-0002Ke-OW for qemu-devel@nongnu.org; Tue, 06 Mar 2012 05:26:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4rbI-0006cv-1m for qemu-devel@nongnu.org; Tue, 06 Mar 2012 05:26:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4rbH-0006cb-Pb for qemu-devel@nongnu.org; Tue, 06 Mar 2012 05:26:35 -0500 Message-ID: <4F55E06E.60404@redhat.com> Date: Tue, 06 Mar 2012 11:01:18 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1330971011-31646-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1330971011-31646-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: handle -EBUSY in bdrv_commit_all() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Am 05.03.2012 19:10, schrieb Stefan Hajnoczi: > Monitor operations that manipulate image files must not execute while a > background job (like image streaming) is in progress. This prevents > corruptions from happening when two pieces of code are manipulating the > image file without knowledge of each other. > > The monitor "commit" command raises QERR_DEVICE_IN_USE when > bdrv_commit() returns -EBUSY but "commit all" has no error handling. > This is easy to fix, although note that we do not deliver a detailed > error about which device was busy in the "commit all" case. > > Suggested-by: Kevin Wolf > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin