From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4vQi-00021y-Pc for qemu-devel@nongnu.org; Tue, 06 Mar 2012 09:32:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4vQc-0006QI-Jl for qemu-devel@nongnu.org; Tue, 06 Mar 2012 09:31:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4vQc-0006QC-Bk for qemu-devel@nongnu.org; Tue, 06 Mar 2012 09:31:50 -0500 Message-ID: <4F561FD0.10900@redhat.com> Date: Tue, 06 Mar 2012 16:31:44 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4F5601BF.3070107@siemens.com> <4F560980.2060803@redhat.com> <4F560C13.4030900@redhat.com> <4F561D8A.4010404@siemens.com> In-Reply-To: <4F561D8A.4010404@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-i386: Mask NX bit from cpu_get_phys_page_debug result List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Blue Swirl , Anthony Liguori , qemu-devel On 03/06/2012 04:22 PM, Jan Kiszka wrote: > This was a long pending bug, now revealed by the assert in > phys_page_find that stumbled over the large page index returned by > cpu_get_phys_page_debug for NX-marked pages: We need to mask out NX and > all user-definable bits 52..62 from PDEs and the final PTE to avoid > corrupting physical addresses. > > Reviewed-by: Avi Kivity -- error compiling committee.c: too many arguments to function