From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34720)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S5K7l-0003z7-IM
	for qemu-devel@nongnu.org; Wed, 07 Mar 2012 11:54:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S5K7R-0004Zx-H2
	for qemu-devel@nongnu.org; Wed, 07 Mar 2012 11:54:01 -0500
Message-ID: <4F578A88.7000200@suse.de>
Date: Wed, 07 Mar 2012 17:19:20 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1331134603-73952-1-git-send-email-cyfdecyf@gmail.com>
In-Reply-To: <1331134603-73952-1-git-send-email-cyfdecyf@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Remove type field in ModuleEntry as it's
 not used.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chen Yufei <cyfdecyf@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

Am 07.03.2012 16:36, schrieb Chen Yufei:
> Signed-off-by: Chen Yufei <cyfdecyf@gmail.com>

There's separate init_type_list[]s per type and the type field is not
even initialized, so:

Acked-by: Andreas F=E4rber <afaerber@suse.de>

Thanks,
Andreas

> ---
>  module.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>=20
> diff --git a/module.c b/module.c
> index 106a969..c3a6da7 100644
> --- a/module.c
> +++ b/module.c
> @@ -19,7 +19,6 @@
> =20
>  typedef struct ModuleEntry
>  {
> -    module_init_type type;
>      void (*init)(void);
>      QTAILQ_ENTRY(ModuleEntry) node;
>  } ModuleEntry;

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg