* [Qemu-devel] [PATCH] Remove type field in ModuleEntry as it's not used.
@ 2012-03-07 15:36 Chen Yufei
2012-03-07 16:19 ` Andreas Färber
2012-03-15 8:17 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Chen Yufei @ 2012-03-07 15:36 UTC (permalink / raw)
To: qemu-trivial; +Cc: Chen Yufei, qemu-devel
Signed-off-by: Chen Yufei <cyfdecyf@gmail.com>
---
module.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/module.c b/module.c
index 106a969..c3a6da7 100644
--- a/module.c
+++ b/module.c
@@ -19,7 +19,6 @@
typedef struct ModuleEntry
{
- module_init_type type;
void (*init)(void);
QTAILQ_ENTRY(ModuleEntry) node;
} ModuleEntry;
--
1.7.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] Remove type field in ModuleEntry as it's not used.
2012-03-07 15:36 [Qemu-devel] [PATCH] Remove type field in ModuleEntry as it's not used Chen Yufei
@ 2012-03-07 16:19 ` Andreas Färber
2012-03-15 8:17 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Färber @ 2012-03-07 16:19 UTC (permalink / raw)
To: Chen Yufei; +Cc: qemu-trivial, qemu-devel
Am 07.03.2012 16:36, schrieb Chen Yufei:
> Signed-off-by: Chen Yufei <cyfdecyf@gmail.com>
There's separate init_type_list[]s per type and the type field is not
even initialized, so:
Acked-by: Andreas Färber <afaerber@suse.de>
Thanks,
Andreas
> ---
> module.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/module.c b/module.c
> index 106a969..c3a6da7 100644
> --- a/module.c
> +++ b/module.c
> @@ -19,7 +19,6 @@
>
> typedef struct ModuleEntry
> {
> - module_init_type type;
> void (*init)(void);
> QTAILQ_ENTRY(ModuleEntry) node;
> } ModuleEntry;
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] Remove type field in ModuleEntry as it's not used.
2012-03-07 15:36 [Qemu-devel] [PATCH] Remove type field in ModuleEntry as it's not used Chen Yufei
2012-03-07 16:19 ` Andreas Färber
@ 2012-03-15 8:17 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-03-15 8:17 UTC (permalink / raw)
To: Chen Yufei; +Cc: qemu-trivial, qemu-devel
On Wed, Mar 07, 2012 at 11:36:43PM +0800, Chen Yufei wrote:
> Signed-off-by: Chen Yufei <cyfdecyf@gmail.com>
> ---
> module.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-15 9:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-07 15:36 [Qemu-devel] [PATCH] Remove type field in ModuleEntry as it's not used Chen Yufei
2012-03-07 16:19 ` Andreas Färber
2012-03-15 8:17 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).