From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52525)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1S5XUo-0007AW-VP
	for qemu-devel@nongnu.org; Thu, 08 Mar 2012 02:10:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1S5XUm-0005Tc-Is
	for qemu-devel@nongnu.org; Thu, 08 Mar 2012 02:10:42 -0500
Received: from [222.73.24.84] (port=6957 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1S5XUm-0005SE-4W
	for qemu-devel@nongnu.org; Thu, 08 Mar 2012 02:10:40 -0500
Message-ID: <4F585BC3.6040802@cn.fujitsu.com>
Date: Thu, 08 Mar 2012 15:12:03 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <1330424430-23015-1-git-send-email-kraxel@redhat.com>
	<1330424430-23015-14-git-send-email-kraxel@redhat.com>
In-Reply-To: <1330424430-23015-14-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 13/21] libcacard: fix reported ATR length
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org

At 02/28/2012 06:20 PM, Gerd Hoffmann Wrote:
> From: Alon Levy <alevy@redhat.com>
>=20
> Signed-off-by: Alon Levy <alevy@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  libcacard/vcardt.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h
> index 538bdde..d4d8e2e 100644
> --- a/libcacard/vcardt.h
> +++ b/libcacard/vcardt.h
> @@ -26,8 +26,8 @@ typedef struct VCardEmulStruct VCardEmul;
>  #define MAX=5FCHANNEL 4
> =20
>  /* create an ATR with appropriate historical bytes */
> -#define VCARD=5FATR=5FPREFIX(size) 0x3b, 0x66+(size), 0x00, 0xff, \
> -                               'V', 'C', 'A', 'R', 'D', '=5F'
> +#define VCARD=5FATR=5FPREFIX(size) (0x3b, 0x68+(size), 0x00, 0xff, \
> +                               'V', 'C', 'A', 'R', 'D', '=5F')
> =20
> =20
>  typedef enum {

qemu build faile with this patch:

  CC    libcacard/vcard=5Femul=5Fnss.o
cc1: warnings being treated as errors
vcard=5Femul=5Fnss.c:528: error: left-hand operand of comma expression has =
no effect
vcard=5Femul=5Fnss.c:528: error: left-hand operand of comma expression has =
no effect
vcard=5Femul=5Fnss.c:528: error: left-hand operand of comma expression has =
no effect
vcard=5Femul=5Fnss.c:528: error: left-hand operand of comma expression has =
no effect
vcard=5Femul=5Fnss.c:528: error: left-hand operand of comma expression has =
no effect
vcard=5Femul=5Fnss.c:528: error: left-hand operand of comma expression has =
no effect
vcard=5Femul=5Fnss.c:528: error: left-hand operand of comma expression has =
no effect
vcard=5Femul=5Fnss.c:528: error: left-hand operand of comma expression has =
no effect
vcard=5Femul=5Fnss.c:528: error: left-hand operand of comma expression has =
no effect
vcard=5Femul=5Fnss.c:528: error: initializer element is not constant
vcard=5Femul=5Fnss.c:528: error: (near initialization for =91nss=5Fatr[0]=
=92)
make[1]: *** [vcard=5Femul=5Fnss.o] Error 1
make: *** [subdir-libcacard] Error 2

I donot know this patch's purpose, so I donot know how to fix it. I guess t=
his
patch is unnecessary.

Thanks
Wen Congyang