From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5hZk-0005QO-1m for qemu-devel@nongnu.org; Thu, 08 Mar 2012 12:56:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5hZi-0004DZ-0T for qemu-devel@nongnu.org; Thu, 08 Mar 2012 12:56:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5hZh-0004DF-Ob for qemu-devel@nongnu.org; Thu, 08 Mar 2012 12:56:25 -0500 Message-ID: <4F58F2BE.90809@redhat.com> Date: Thu, 08 Mar 2012 10:56:14 -0700 From: Eric Blake MIME-Version: 1.0 References: <1331225951-31306-1-git-send-email-mark.langsdorf@calxeda.com> In-Reply-To: <1331225951-31306-1-git-send-email-mark.langsdorf@calxeda.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig16ECF9CB64D60F10A40CB740" Subject: Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Langsdorf Cc: david@gibson.dropbear.id.au, qemu-devel@nongnu.org, agraf@suse.de This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig16ECF9CB64D60F10A40CB740 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/08/2012 09:59 AM, Mark Langsdorf wrote: > Allow load_image_targphys to load files on systems with more than 2G of= > emulated memory by changing the max_sz parameter from an int to an > unsigned long. unsigned long is still 32-bits on a 32-bit host. You probably want to be using off_t. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig16ECF9CB64D60F10A40CB740 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPWPK+AAoJEKeha0olJ0NqY4gH+wYd8GFznhW0zbBtnDsqvcBu FcLlim8euvArAwrhsD5ws/9gKIqNXCZK7hFHlZ8cCXwaBuf8XCAGKCpAWEI9G7KT 0sFE4kHpkTLquZyATKu9HCoGLagnLnyWRrgWVH8gdfnqIodUkodrobpCfzMDyCgE bKJ4ThKaE26ZWWu/L4OrDvcNj/SvL73ZaKOsPPdSPiQOgiG1dnKEh2QD008pJ9XR tTc3d5F9fWZBUBUqMYIgx8IWKWm+YKZSlldIBiE/WkS8Aan3aW/++XQ9koX9gwh7 rxc6qXPLSbH54rTdZfeT/uq/yjzdE2n+GRFhNTUNYFeJ0lMspLhnImi+UMnV1Yw= =t+Wd -----END PGP SIGNATURE----- --------------enig16ECF9CB64D60F10A40CB740--