From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5vYl-00053N-2R for qemu-devel@nongnu.org; Fri, 09 Mar 2012 03:52:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5vYg-0006NX-GI for qemu-devel@nongnu.org; Fri, 09 Mar 2012 03:52:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5vYg-0006ND-7w for qemu-devel@nongnu.org; Fri, 09 Mar 2012 03:52:18 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q298qFfd018461 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 9 Mar 2012 03:52:15 -0500 Message-ID: <4F59C4BD.4060600@redhat.com> Date: Fri, 09 Mar 2012 09:52:13 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1331198182-11516-1-git-send-email-kraxel@redhat.com> <1331198182-11516-2-git-send-email-kraxel@redhat.com> <4F59C09D.3090402@redhat.com> <4F59C282.5090804@redhat.com> In-Reply-To: <4F59C282.5090804@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RfC PATCH 1/2] usb: the big rename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Il 09/03/2012 09:42, Gerd Hoffmann ha scritto: >>> emulations are prefixed with "dev-". Fixup paths Makefile and include >>> >> paths to make it compile. No code changes. >> > >> > Let's start using include/usb instead? > I think that needs a few more cleanups beforehand, there is a single > usb.h now, guess I better should split that into usb-private and > external-interfaces first. > > Also IIRC include/ is (also?) meant for the data structures code > generators (qapi, visitors) want look at. As I understood it, the idea is to make it simply Linux-like, with public headers in include/ and private headers elsewhere. So even interfaces that are private to the USB layer, but shared among multiple directories would be in include/. I suppose the external interfaces are just to support legacy command-line and the like? Paolo