From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5we6-0003dx-0Z for qemu-devel@nongnu.org; Fri, 09 Mar 2012 05:02:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5we4-0001sM-8W for qemu-devel@nongnu.org; Fri, 09 Mar 2012 05:01:57 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:56086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5we4-0001s4-1J for qemu-devel@nongnu.org; Fri, 09 Mar 2012 05:01:56 -0500 Received: by iafj26 with SMTP id j26so2136402iaf.4 for ; Fri, 09 Mar 2012 02:01:54 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F59D4EC.7060506@redhat.com> Date: Fri, 09 Mar 2012 11:01:16 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1331269308-22372-1-git-send-email-david@gibson.dropbear.id.au> <1331269308-22372-2-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1331269308-22372-2-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Kevin Wolf , mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, eduard.munteanu@linux360.ro, rth@twiddle.net Il 09/03/2012 06:01, David Gibson ha scritto: > Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > determine the direction of DMA it is emulating. We already have a > DMADirection enum designed specifically to encode DMA directions. > This patch uses it for dma_bdrv_io() as well. This involves removing > the DMADirection definition from the #ifdef it was inside, but since that > only existed to protect the definition of dma_addr_t from places where > config.h is not included, there wasn't any reason for it to be there in > the first place. Looks good, but please use this for dma_buf_* too. Paolo