From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5xVb-0001Zn-8y for qemu-devel@nongnu.org; Fri, 09 Mar 2012 05:57:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5xVV-00047f-9U for qemu-devel@nongnu.org; Fri, 09 Mar 2012 05:57:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5xVV-00047N-18 for qemu-devel@nongnu.org; Fri, 09 Mar 2012 05:57:09 -0500 Message-ID: <4F59E200.3040104@redhat.com> Date: Fri, 09 Mar 2012 11:57:04 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1331226917-6658-1-git-send-email-pbonzini@redhat.com> <1331226917-6658-15-git-send-email-pbonzini@redhat.com> <4F59DEC6.8010509@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 14/17] block: support FALLOC_FL_PUNCH_HOLE trimming List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Il 09/03/2012 11:53, Stefan Hajnoczi ha scritto: > >> > 1) require a new-enough kernel and only use fallocate; return a NULL >> > aiocb if !has_discard and convert it to ENOTSUP. >> > >> > 2) extract now from my threads branch the work to generalize >> > posix-aio-compat into a more flexible threadpool, and move the AIO code >> > back to block/raw-posix.c. > 3) Add discard to posix-aio-compat.c as an AIO request? That would be (1) or you would need to pass down is_xfs. Paolo