From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52699)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S5yYj-00086L-6D
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 07:04:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S5yYd-0001kc-1L
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 07:04:32 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:65273)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S5yYc-0001kH-TL
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 07:04:26 -0500
Received: by ghrr14 with SMTP id r14so929624ghr.4
	for <qemu-devel@nongnu.org>; Fri, 09 Mar 2012 04:04:25 -0800 (PST)
Message-ID: <4F59F1C7.5000008@codemonkey.ws>
Date: Fri, 09 Mar 2012 06:04:23 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <20120308144958.GA25750@t420s.optimusnet>
	<4F58C897.5020405@codemonkey.ws>
	<20120308150722.GA30576@t420s.optimusnet>
	<4F58CCBA.9000702@codemonkey.ws>
	<20120308160505.GA32360@t420s.optimusnet>
	<4F58E67A.3050708@codemonkey.ws>
	<20120308175907.GA4900@t420s.optimusnet>
	<4F5905AA.3060304@codemonkey.ws>
	<20120308210209.GA11998@t420s.optimusnet>
	<4F59237F.6010406@codemonkey.ws>
	<20120308222433.GB11998@t420s.optimusnet>
	<4F593F08.8050606@codemonkey.ws> <4F59E77B.7080806@redhat.com>
In-Reply-To: <4F59E77B.7080806@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization
 tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: cleber@redhat.com
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>, Scott Zawalski <scottz@google.com>, Ademar Reis <areis@redhat.com>, QEMU devel <qemu-devel@nongnu.org>, Cleber Rosa <crosa@redhat.com>

On 03/09/2012 05:20 AM, Cleber Rosa wrote:
>>> You're comparing developer-level tests with the existent QA-level
>>> tests (much more complex).
>>
>> Let's be specific then. Look at device-add.sh in qemu-test. It's 71LOC.
>> pci_hotplug.py in autotest is 204LOC.
>
> pci_hotplug.py does much more than device-add.sh:
>
> * tests both pci_add and device_add commands
> * checks the monitor syntax for adding a new drive, that is, it works on HEAD
> and on other versions (such as the ones in some RHEL releases);
> * tests both nic and block hotplug
> * for block, tests with both virtio and scsi
> * also does device removal, both for pci_add and device_add syntaxes

Ok, but clearly, there's no magic in autotest that makes this sufficiently 
easier.  It's just a matter of:

cmd=`named_choose command device_add pci_add`

if test $cmd = "device_add"; then
   qmp device_add --driver=virtio-blk-pci --drive=hd0
else
   hmp pci_add auto virtio-blk-pci,drive=hd0
fi

It's not there today because pci_add is deprecated.  There assertion was that 
autotest makes it easier to write tests.  How does it make it easier to write 
pci_hotplug?

Regards,

Anthony Liguori