From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S60On-0002iH-Oj
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 09:02:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S60Oi-0003Wd-SS
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 09:02:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:18632)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S60Oi-0003WO-JC
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 09:02:20 -0500
Message-ID: <4F5A0E3B.1080200@redhat.com>
Date: Fri, 09 Mar 2012 15:05:47 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1331297197-4289-1-git-send-email-kwolf@redhat.com>
	<1331297197-4289-4-git-send-email-kwolf@redhat.com>
	<4F5A0519.8020307@suse.de>
In-Reply-To: <4F5A0519.8020307@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 3/3] Add 'make check-block'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org

Am 09.03.2012 14:26, schrieb Andreas F=E4rber:
> Am 09.03.2012 13:46, schrieb Kevin Wolf:
>> Runs the full qemu-iotests suite for various image formats.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>>  tests/Makefile       |    6 +++++-
>>  tests/check-block.sh |   21 +++++++++++++++++++++
>>  2 files changed, 26 insertions(+), 1 deletions(-)
>>  create mode 100755 tests/check-block.sh
>>
>> diff --git a/tests/Makefile b/tests/Makefile
>> index 571ad42..6b4f4aa 100644
>> --- a/tests/Makefile
>> +++ b/tests/Makefile
>> @@ -47,6 +47,10 @@ test-qmp-commands: test-qmp-commands.o $(qobject-ob=
j-y) $(qapi-obj-y) $(tools-ob
>> =20
>>  $(SRC_PATH)/tests/qemu-iotests-quick.sh: qemu-img qemu-io
>> =20
>> -.PHONY: check
>> +
>> +.PHONY: check check-block
>=20
> Minor nit: Since you already add a second empty line before .PHONY, car=
e
> to also add one before check: analog to check-block:?

Sure.

>>  check: $(CHECKS)
>>  	$(call quiet-command, gtester $(CHECKS), "  CHECK")
>> +
>> +check-block:
>> +	$(call quiet-command, $(SRC_PATH)/tests/check-block.sh , "  CHECK")
>=20
> Please use $(SHELL) here.

Ok, I can do that. But what's the difference?

Kevin