From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S60SJ-0006d6-4D for qemu-devel@nongnu.org; Fri, 09 Mar 2012 09:06:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S60SA-0004mq-Fq for qemu-devel@nongnu.org; Fri, 09 Mar 2012 09:06:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S60SA-0004mC-6j for qemu-devel@nongnu.org; Fri, 09 Mar 2012 09:05:54 -0500 Message-ID: <4F5A0F12.60904@redhat.com> Date: Fri, 09 Mar 2012 15:09:22 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1331297197-4289-1-git-send-email-kwolf@redhat.com> <1331297197-4289-3-git-send-email-kwolf@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/3] make check: Add qemu-iotests subset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Am 09.03.2012 14:20, schrieb Stefan Hajnoczi: > On Fri, Mar 9, 2012 at 12:46 PM, Kevin Wolf wrote: >> Run the 'quick' group from qemu-iotests during 'make check'. >> >> Signed-off-by: Kevin Wolf >> --- >> tests/Makefile | 5 +++++ >> tests/qemu-iotests-quick.sh | 17 +++++++++++++++++ >> 2 files changed, 22 insertions(+), 0 deletions(-) >> create mode 100755 tests/qemu-iotests-quick.sh >> >> diff --git a/tests/Makefile b/tests/Makefile >> index 74b29dc..571ad42 100644 >> --- a/tests/Makefile >> +++ b/tests/Makefile >> @@ -1,6 +1,9 @@ >> +export SRC_PATH > > I'm not sure I like this. Could we avoid this with: > > cd $(dirname "$0")/tests/qemu-iotests > > instead of using SRC_PATH in qemu-iotests-quick.sh? Do you really like this better? To me it doesn't feel cleaner. Kevin