From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S61q1-0003BX-GW for qemu-devel@nongnu.org; Fri, 09 Mar 2012 10:34:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S61ps-0005AZ-SY for qemu-devel@nongnu.org; Fri, 09 Mar 2012 10:34:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S61ps-0005AQ-K6 for qemu-devel@nongnu.org; Fri, 09 Mar 2012 10:34:28 -0500 Message-ID: <4F5A22FE.2070802@redhat.com> Date: Fri, 09 Mar 2012 16:34:22 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <4F582EDB.1040608@redhat.com> <4F58B5CB.8040503@codemonkey.ws> <4F58CDEA.2020506@redhat.com> <4F59010C.2060105@codemonkey.ws> <4F5909B3.4080405@redhat.com> <4F590BD7.6030605@codemonkey.ws> <4F5913F3.3040503@redhat.com> <4F591EB4.1090300@codemonkey.ws> <4F5A076E.9040904@redhat.com> <4F5A0D49.60200@codemonkey.ws> <4F5A13FA.6040606@redhat.com> <4F5A1729.5060206@codemonkey.ws> <4F5A1B25.6070306@redhat.com> <4F5A1B86.4070806@codemonkey.ws> <4F5A1F18.3010006@redhat.com> <4F5A20A5.5050808@codemonkey.ws> In-Reply-To: <4F5A20A5.5050808@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Lucas Meneghel Rodrigues , Cleber Rosa , QEMU devel , Ademar Reis Il 09/03/2012 16:24, Anthony Liguori ha scritto: >> At the very least dump the inquiry pages, mode pages, etc. and see that >> they make sense and correspond to the device properties. > > Is this not something that's reasonably easy to do in qtest? Yes (at least with virtio-scsi the libos bits are relatively small; just think of what it would have been like when the only HBA was LSI), but with one gotcha... > Is it possible to write a C program that does the ioctl and dump the > inquiry page in a text format conducive to shell parsing? ... sg_utils also parses the pages and dumps them in human-readable format. This is useful because it provides a completely separate implementation and avoids problems with misinterpretation of the standard. Of course it would work just as well if someone wrote tests instead of me. >>> Are these the sort of tests that would be interesting to also run on >>> Fedora, Windows, and Ubuntu? >> >> They should give exactly the same output on any guest. > > Is it valuable to have a per-platform test or since this is mostly > passthrough to the device (I assume), do you just need a single test? Ah, understood. Yeah, a single test is enough for the purpose of testing QEMU. If you want to test the driver too, running under Windows would be useful. Paolo