From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: libvir-list@redhat.com, Khoa Huynh <khoa@us.ibm.com>,
George Wilson <gcwilson@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>, Laine Stump <laine@laine.org>
Subject: Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy
Date: Fri, 09 Mar 2012 18:16:54 +0100 [thread overview]
Message-ID: <4F5A3B06.4000302@redhat.com> (raw)
In-Reply-To: <CAJSP0QVaxmzxtF3Pko1JA2ty_W2_y92EX0FDFExJw422GuuZDw@mail.gmail.com>
Il 09/03/2012 17:07, Stefan Hajnoczi ha scritto:
>> > So am I correct that this extra permission is only needed for a single
>> > RHEL6 release? If qemu won't be doing fstafs on an ongoing basis, it
>> > doesn't seem like a good idea to permanently open up the permissions
>> > allowed by virt_use_nfs
> Paolo, your discard improvements in QEMU add FALLOC_FL_PUNCH_HOLE
> support. XFS supports this fallocate() flag in current kernels,
> thereby making the XFS-specific support obsolete.
>
> I'm wondering whether it's worth expanding the SELinux policy if we
> will have no fstatfs(2) callers in QEMU. Are you planning to drop the
> XFS code?
Chris Wedgwood said that on XFS you want to do discard even if the file
is preallocated, while this is not true on other filesystems. So I
guess the detection code should stay.
Paolo
next prev parent reply other threads:[~2012-03-09 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 11:32 [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy Stefan Hajnoczi
2012-03-09 14:16 ` Jiri Denemark
2012-03-09 15:11 ` Laine Stump
2012-03-09 15:19 ` Stefan Hajnoczi
2012-03-09 16:07 ` Stefan Hajnoczi
2012-03-09 17:16 ` Paolo Bonzini [this message]
2012-03-10 7:30 ` Stefan Hajnoczi
2012-03-24 14:47 ` Christoph Hellwig
2012-03-24 14:46 ` Christoph Hellwig
2012-03-09 15:23 ` George Wilson
2012-03-09 16:08 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A3B06.4000302@redhat.com \
--to=pbonzini@redhat.com \
--cc=gcwilson@us.ibm.com \
--cc=khoa@us.ibm.com \
--cc=laine@laine.org \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).