From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64R5-00059X-Dh for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:21:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S64R3-00089h-Rn for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:21:02 -0500 Received: from thoth.sbs.de ([192.35.17.2]:34311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64R3-00089E-HG for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:21:01 -0500 Message-ID: <4F5A4A08.8030805@siemens.com> Date: Fri, 09 Mar 2012 19:20:56 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1331316786-7752-1-git-send-email-lcapitulino@redhat.com> <1331316786-7752-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1331316786-7752-4-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: "pbonzini@redhat.com" , "aliguori@us.ibm.com" , "qemu-devel@nongnu.org" , "quintela@redhat.com" On 2012-03-09 19:13, Luiz Capitulino wrote: > The Monitor object is passed back and forth within the migration/savevm > code so that it can print errors and progress to the user. > > However, that approach assumes a HMP monitor, being completely invalid > in QMP. > > This commit drops almost every single usage of the Monitor object, all > monitor_printf() calls have been converted into DPRINTF() ones. I guess for most printfs, this is OK. But do you provide an alternative for the block migration progress output? I did not find anything on first glance. That is not a debugging feature. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux