From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64Wp-0008JV-5i for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:27:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S64Wn-00012k-0j for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:26:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64Wm-00012a-OY for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:26:56 -0500 Message-ID: <4F5A4B6D.8080606@redhat.com> Date: Fri, 09 Mar 2012 11:26:53 -0700 From: Eric Blake MIME-Version: 1.0 References: <1331316786-7752-1-git-send-email-lcapitulino@redhat.com> <1331316786-7752-5-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1331316786-7752-5-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig3B4CAB838AB7E83170E50086" Subject: Re: [Qemu-devel] [PATCH 4/4] qapi: Convert migrate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: pbonzini@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, jan.kiszka@siemens.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3B4CAB838AB7E83170E50086 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/09/2012 11:13 AM, Luiz Capitulino wrote: > The migrate command is one of those commands where HMP and QMP complete= ly > mix up together. This made the conversion to the QAPI (which separates = the > command into QMP and HMP parts) a bit difficult. >=20 > The first important change to be noticed is that this commit completes = the > removal of the Monitor object from migration code, started by the previ= ous > commit. >=20 > Another important and tricky change is about supporting the non-detache= d > mode. That's, if the user doesn't pass '-d' the migrate command will lo= ck As a native speaker, I can state that it is unusual or even wrong to see a contraction immediately before a comma. I would do: s/That's,/That is,/ > the monitor and will only release it when migration is finished. >=20 > To support that in the new HMP command (hmp_migrate()), it is necessary= > to create a timer which runs every second and checks if the migration i= s > still active. If it's, the timer callback will re-schedule itself to ru= n Another instance of the same grammar problem: s/it's/it is/ > one second in the future. If the migration has already finished, the > monitor lock is relased and the user can use it normally. s/relased/released/ >=20 > All these changes should be transparent to the user. >=20 > +++ b/qapi-schema.json > @@ -1631,3 +1631,24 @@ > { 'command': 'qom-list-types', > 'data': { '*implements': 'str', '*abstract': 'bool' }, > 'returns': [ 'ObjectTypeInfo' ] } > + > +## > +# @migrate > +# > +# Migrates the current running guest to another Virtual Machine. > +# > +# @uri: the Uniform Resource Identifier of the destination VM > +# > +# @blk: #optional do block migration (full disk copy) > +# > +# @inc: #optional incremental disk copy migration > +# > +# @detach: this argument exists only for compatibility reasons and sho= uld not > +# be used. Libvirt is currently using it, but it appears that libvirt always sets it to true. Does this mean the argument is ignored no matter whether you pass true or false? Or does this value have a default if omitted, and it is safe to explicitly pass the default (I assume the default is true), and that it is wrong to pass an explicit value that contradicts the default (that is, I'm assuming passing an explicit 'detach':'false' is wrong)? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig3B4CAB838AB7E83170E50086 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPWkttAAoJEKeha0olJ0NqWboH+wfW/I9IJUIzJSWI2MwZZZ9M abtjWHMfuWAaPTRoFr6g/oI4w+71O0DCSjOeTL6ZkUIIU7OZCMBwSAKTWZJW/+X7 JbS8VJJ258s2RPKA4Q7QwWBHcwshuR6blSQL/Wtmg1SYbiRU+1TSUt5acO+Q2B7C Fd7sgQ1NSw7uxW5VWpT1dX7iMDuEKr/dv48xt32xjvrFJiUYe2dHagdjQoC+w5aM z8xOk/BZTQXLJr6o46kSVZMcW5oQsBbbaTpMbvUMYh1p0iK5Wdpx+7sCxnOw1Crr 3vYL6xqqXffj9JipfIxMyeESS0hGZow90qLRJW/NaVxfPJ0V+B6bJ82wXCjDhz4= =cIAJ -----END PGP SIGNATURE----- --------------enig3B4CAB838AB7E83170E50086--