From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64bu-0002sN-GF for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:32:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S64bs-0002PK-NR for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:32:14 -0500 Received: from e36.co.us.ibm.com ([32.97.110.154]:35045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64bs-0002Oa-HV for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:32:12 -0500 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 9 Mar 2012 11:32:07 -0700 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 277CA3E40036 for ; Fri, 9 Mar 2012 11:32:04 -0700 (MST) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q29IVuZc151008 for ; Fri, 9 Mar 2012 11:31:58 -0700 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q29IVtE1026359 for ; Fri, 9 Mar 2012 11:31:56 -0700 Message-ID: <4F5A4C98.6050401@us.ibm.com> Date: Fri, 09 Mar 2012 12:31:52 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1331316786-7752-1-git-send-email-lcapitulino@redhat.com> <1331316786-7752-4-git-send-email-lcapitulino@redhat.com> <4F5A4A08.8030805@siemens.com> In-Reply-To: <4F5A4A08.8030805@siemens.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "pbonzini@redhat.com" , "quintela@redhat.com" , "qemu-devel@nongnu.org" , Luiz Capitulino On 03/09/2012 12:20 PM, Jan Kiszka wrote: > On 2012-03-09 19:13, Luiz Capitulino wrote: >> The Monitor object is passed back and forth within the migration/savevm >> code so that it can print errors and progress to the user. >> >> However, that approach assumes a HMP monitor, being completely invalid >> in QMP. >> >> This commit drops almost every single usage of the Monitor object, all >> monitor_printf() calls have been converted into DPRINTF() ones. > > I guess for most printfs, this is OK. But do you provide an alternative > for the block migration progress output? I did not find anything on > first glance. That is not a debugging feature. The block migration progress stuff is horribly broken and I regret ever merging it. Are you actively relying on this? Does block migration even work? Could we just remove block migration entirely... Regards, Anthony Liguori > > Jan >