From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64fS-0005kS-3x for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:35:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S64fP-00039g-K6 for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:35:53 -0500 Received: from e38.co.us.ibm.com ([32.97.110.159]:48077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64fP-00039C-DP for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:35:51 -0500 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 9 Mar 2012 11:35:47 -0700 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 45A31C9005A for ; Fri, 9 Mar 2012 13:35:45 -0500 (EST) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q29IZjjQ269130 for ; Fri, 9 Mar 2012 13:35:45 -0500 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q29IZitL027433 for ; Fri, 9 Mar 2012 13:35:44 -0500 Message-ID: <4F5A4D74.4090702@us.ibm.com> Date: Fri, 09 Mar 2012 12:35:32 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1331316786-7752-1-git-send-email-lcapitulino@redhat.com> <1331316786-7752-5-git-send-email-lcapitulino@redhat.com> <4F5A4B6D.8080606@redhat.com> In-Reply-To: <4F5A4B6D.8080606@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] qapi: Convert migrate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: pbonzini@redhat.com, quintela@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, Luiz Capitulino On 03/09/2012 12:26 PM, Eric Blake wrote: > On 03/09/2012 11:13 AM, Luiz Capitulino wrote: >> The migrate command is one of those commands where HMP and QMP completely >> mix up together. This made the conversion to the QAPI (which separates the >> command into QMP and HMP parts) a bit difficult. >> >> The first important change to be noticed is that this commit completes the >> removal of the Monitor object from migration code, started by the previous >> commit. >> >> Another important and tricky change is about supporting the non-detached >> mode. That's, if the user doesn't pass '-d' the migrate command will lock > > As a native speaker, I can state that it is unusual or even wrong to see > a contraction immediately before a comma. I would do: > > s/That's,/That is,/ > >> the monitor and will only release it when migration is finished. >> >> To support that in the new HMP command (hmp_migrate()), it is necessary >> to create a timer which runs every second and checks if the migration is >> still active. If it's, the timer callback will re-schedule itself to run > > Another instance of the same grammar problem: > > s/it's/it is/ > >> one second in the future. If the migration has already finished, the >> monitor lock is relased and the user can use it normally. > > s/relased/released/ > >> >> All these changes should be transparent to the user. >> > >> +++ b/qapi-schema.json >> @@ -1631,3 +1631,24 @@ >> { 'command': 'qom-list-types', >> 'data': { '*implements': 'str', '*abstract': 'bool' }, >> 'returns': [ 'ObjectTypeInfo' ] } >> + >> +## >> +# @migrate >> +# >> +# Migrates the current running guest to another Virtual Machine. >> +# >> +# @uri: the Uniform Resource Identifier of the destination VM >> +# >> +# @blk: #optional do block migration (full disk copy) >> +# >> +# @inc: #optional incremental disk copy migration >> +# >> +# @detach: this argument exists only for compatibility reasons and should not >> +# be used. > > Libvirt is currently using it, but it appears that libvirt always sets > it to true. Does this mean the argument is ignored no matter whether > you pass true or false? Yes, and we should specify that. The argument is ignored by QEMU. Regards, Anthony Liguori