From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64on-00018C-DI for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:45:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S64og-0004zl-WC for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:45:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64og-0004zQ-ON for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:45:26 -0500 Message-ID: <4F5A4FC2.7020501@redhat.com> Date: Fri, 09 Mar 2012 11:45:22 -0700 From: Eric Blake MIME-Version: 1.0 References: <1331316786-7752-1-git-send-email-lcapitulino@redhat.com> <1331316786-7752-4-git-send-email-lcapitulino@redhat.com> <4F5A4A08.8030805@siemens.com> <4F5A4C98.6050401@us.ibm.com> In-Reply-To: <4F5A4C98.6050401@us.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig8BE3E34AA53C91772670844F" Subject: Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Luiz Capitulino , Jan Kiszka , "quintela@redhat.com" , "qemu-devel@nongnu.org" , "pbonzini@redhat.com" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8BE3E34AA53C91772670844F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/09/2012 11:31 AM, Anthony Liguori wrote: > On 03/09/2012 12:20 PM, Jan Kiszka wrote: >> On 2012-03-09 19:13, Luiz Capitulino wrote: >>> The Monitor object is passed back and forth within the migration/save= vm >>> code so that it can print errors and progress to the user. >>> >>> However, that approach assumes a HMP monitor, being completely invali= d >>> in QMP. >>> >>> This commit drops almost every single usage of the Monitor object, al= l >>> monitor_printf() calls have been converted into DPRINTF() ones. >> >> I guess for most printfs, this is OK. But do you provide an alternativ= e >> for the block migration progress output? I did not find anything on >> first glance. That is not a debugging feature. >=20 > The block migration progress stuff is horribly broken and I regret ever= > merging it. Are you actively relying on this? >=20 > Does block migration even work? >=20 > Could we just remove block migration entirely... Libvirt has already exposed block migration to users, but it is untested; if, as you say, it is horribly broken, then libvirt needs to pass on the error message back to the user that it is broken. But we regularly get people complaining that they don't have shared storage set up, and they are looking for a magic bullet that will do block migration alongside the domain migration; perhaps libvirt can still provide that with block mirroring or other (working) solutions from the same API it gives to the user if you end up pulling it out of the migrate QMP command. At the end of the day, it's your call whether to pull it out, and libvirt will adapt, but it would be nice to know what kosher working alternative(s) to use instead. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig8BE3E34AA53C91772670844F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPWk/CAAoJEKeha0olJ0NqJ90IAJq4to7cMRwioVj/FCxCtTng 62GFzZwjiLSALxNgR294emacrVs6f6m5EoazGzd38RyJCjPUUfciYbAsu9tYlGke XCwMe3dKwT4a+7dS91+GOjqhQV7s8NRkZo5PcTBktWhvKJJGhjuzMhEl4G/nHsUi MDh9FqgoiRtOUCYr/lQ4vt2r8Ep1ugfXj4WNaXvc/nfaUsnt8Ri+lJQyDFpesGwI 9z02fYGm2CzztTCl0f0pHlZT/wXtGf3am3hC5PkhdJAsx+nVRrtRbSqAmpdMS1rb 60bs6cKT9mlesistbJiVtxRr+Zr7JNJlC8Kjs+nRfcAmovixoxNttP2camCrvKE= =QeTG -----END PGP SIGNATURE----- --------------enig8BE3E34AA53C91772670844F--