From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S65FI-00031d-F2 for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:12:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S65FG-0001Ih-Iq for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:12:56 -0500 Received: from e35.co.us.ibm.com ([32.97.110.153]:34499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S65FG-0001ID-Bm for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:12:54 -0500 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 9 Mar 2012 12:12:49 -0700 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 4070719D804A for ; Fri, 9 Mar 2012 12:12:41 -0700 (MST) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q29JCksl194396 for ; Fri, 9 Mar 2012 12:12:46 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q29JCjbF026557 for ; Fri, 9 Mar 2012 12:12:45 -0700 Message-ID: <4F5A562B.8000109@us.ibm.com> Date: Fri, 09 Mar 2012 13:12:43 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1331316786-7752-1-git-send-email-lcapitulino@redhat.com> <1331316786-7752-4-git-send-email-lcapitulino@redhat.com> <4F5A4A08.8030805@siemens.com> <20120309153019.32846104@doriath.home> <4F5A5463.9010803@siemens.com> In-Reply-To: <4F5A5463.9010803@siemens.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "pbonzini@redhat.com" , "quintela@redhat.com" , "qemu-devel@nongnu.org" , Luiz Capitulino On 03/09/2012 01:05 PM, Jan Kiszka wrote: > On 2012-03-09 19:30, Luiz Capitulino wrote: >> On Fri, 09 Mar 2012 19:20:56 +0100 >> Jan Kiszka wrote: >> >>> On 2012-03-09 19:13, Luiz Capitulino wrote: >>>> The Monitor object is passed back and forth within the migration/savevm >>>> code so that it can print errors and progress to the user. >>>> >>>> However, that approach assumes a HMP monitor, being completely invalid >>>> in QMP. >>>> >>>> This commit drops almost every single usage of the Monitor object, all >>>> monitor_printf() calls have been converted into DPRINTF() ones. >>> >>> I guess for most printfs, this is OK. But do you provide an alternative >>> for the block migration progress output? I did not find anything on >>> first glance. That is not a debugging feature. >> >> Can't the info migrate command be used for that? > > This was introduced for synchronous migration, as usability improvement. Synchronous migration doesn't exist in QMP. It's certainly possible to make the synchronous monitor command spit out status as it already uses a polling loop to determine when migration completes. Regards, Anthony Liguori > > Either we expose this feature or we drop it completely. But converting > it to a /dev/null output is pointless. > > Jan >