From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46828)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S65Tc-0008Ld-RH
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:27:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S65Tb-0003sB-0v
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:27:44 -0500
Received: from mail-pz0-f45.google.com ([209.85.210.45]:43870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S65Ta-0003ry-R5
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:27:42 -0500
Received: by dadp14 with SMTP id p14so1976977dad.4
	for <qemu-devel@nongnu.org>; Fri, 09 Mar 2012 11:27:40 -0800 (PST)
Message-ID: <4F5A59A9.2060604@codemonkey.ws>
Date: Fri, 09 Mar 2012 13:27:37 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1330703384-17447-1-git-send-email-hdegoede@redhat.com>
In-Reply-To: <1330703384-17447-1-git-send-email-hdegoede@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org

On 03/02/2012 09:49 AM, Hans de Goede wrote:
> VCARD_ATR_PREFIX is used as part of an array initializer so it should
> not have () around it, so far this happened to work, but gcc-4.7 does
> not like it.
>
> Signed-off-by: Hans de Goede<hdegoede@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   libcacard/vcardt.h |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h
> index d4d8e2e..d3e9522 100644
> --- a/libcacard/vcardt.h
> +++ b/libcacard/vcardt.h
> @@ -26,8 +26,8 @@ typedef struct VCardEmulStruct VCardEmul;
>   #define MAX_CHANNEL 4
>
>   /* create an ATR with appropriate historical bytes */
> -#define VCARD_ATR_PREFIX(size) (0x3b, 0x68+(size), 0x00, 0xff, \
> -                               'V', 'C', 'A', 'R', 'D', '_')
> +#define VCARD_ATR_PREFIX(size) 0x3b, 0x68+(size), 0x00, 0xff, \
> +                               'V', 'C', 'A', 'R', 'D', '_'
>
>
>   typedef enum {