From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S65oZ-0008AS-SU for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:49:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S65oF-00080u-5R for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:49:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S65oE-0007zg-TI for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:49:03 -0500 Message-ID: <4F5A5EAB.1090407@redhat.com> Date: Fri, 09 Mar 2012 12:48:59 -0700 From: Eric Blake MIME-Version: 1.0 References: <1331316786-7752-1-git-send-email-lcapitulino@redhat.com> <1331316786-7752-4-git-send-email-lcapitulino@redhat.com> <4F5A4A08.8030805@siemens.com> <4F5A4C98.6050401@us.ibm.com> <4F5A4FC2.7020501@redhat.com> <4F5A51B8.9030806@us.ibm.com> <4F5A5D3F.6090403@redhat.com> In-Reply-To: <4F5A5D3F.6090403@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig7E9066CD7CAFBD4F50859528" Subject: Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Anthony Liguori , "quintela@redhat.com" , Jan Kiszka , "qemu-devel@nongnu.org" , Luiz Capitulino , "pbonzini@redhat.com" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7E9066CD7CAFBD4F50859528 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/09/2012 12:42 PM, Eric Blake wrote: > On 03/09/2012 11:53 AM, Anthony Liguori wrote: >>>> >>>> Could we just remove block migration entirely... >>> >>> Libvirt has already exposed block migration to users, >> >> :-( >> >> Do you rely on the progress stats that are printed? >=20 > I've never personally used it (as I said earlier, the libvirt support > for blk and inc doesn't get much testing), but I can state that if you = do: >=20 > virsh migrate --copy-storage-all --copy-storage-inc --verbose ... >=20 > that virsh will cause libvirt to start up a detached migration, then > repeatedly call the query-migrate monitor command to update an on-scree= n > progress monitor to the user; this progress monitor tracks both ram and= > disk status to compute the percentage complete showed to the user, so a= t > some level, libvirt really is trying to rely on accurate block migratio= n > progress numbers. Just realized I wasn't very clear: libvirt does _not_ play back qemu's status numbers, so much as computing its _own_ progress monitor based on parsing the output of the repeated query-migrate commands. And since libvirt tends to favor QMP over HMP, the only monitoring we need from QMP is what we query for; we don't need HMP-style update messages. Having HMP update a progress line each time it rearms the one second timer while waiting for the migration to complete is probably good enough for HMP, and libvirt won't care. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig7E9066CD7CAFBD4F50859528 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPWl6rAAoJEKeha0olJ0NqIikIAJUEn7YlMh7d5FG/oJQpYzxH GpJC2vzYmB47uLOLAXmXPAac9Ai9rYs+aLJ6/IrJETtaIZ4izXQXwJXnTsKDluHM 76RB0//BsLqNDtCCkpRZ3JeRYxHF5LFVGANiusIxA2R2DotNHb0Y5cWShT7T+m4D sB/zGslSCHlufCO9LV2g9/jqEPOKGA9ScvR9p8A17S1vxFPLnu/0bi7RgQgCQPkE iyHIQVnu3XKVHNlfQfuDUZPH6rsAJlI13f+8N3Uv1eR951P4xDa3rS6yOrsOUhjY 3iMCb5SKBqBHnT5EZJhnQ6PvvCX5+T0fMmYItCjOKojjd50sLGQCAD6RY1zxsGc= =wiIP -----END PGP SIGNATURE----- --------------enig7E9066CD7CAFBD4F50859528--