qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: Test for libiberty.a (mingw32)
Date: Sat, 10 Mar 2012 19:47:20 +0100	[thread overview]
Message-ID: <4F5BA1B8.80606@weilnetz.de> (raw)
In-Reply-To: <4F5B814B.2050602@suse.de>

Am 10.03.2012 17:28, schrieb Andreas Färber:
> Am 10.03.2012 11:14, schrieb Stefan Weil:
>> MinGW-w64 and some versions of MinGW32 don't provide libiberty.a,
>> so add this library only if it was found.
>
> What do we need it for at all then?
>
> Andreas
>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> configure | 8 +++++++-
>> 1 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/configure b/configure
>> index ca25250..bb16498 100755
>> --- a/configure
>> +++ b/configure
>> @@ -511,7 +511,13 @@ if test "$mingw32" = "yes" ; then
>> QEMU_CFLAGS="-DWIN32_LEAN_AND_MEAN -DWINVER=0x501 $QEMU_CFLAGS"
>> # enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later)
>> QEMU_CFLAGS="-D__USE_MINGW_ANSI_STDIO=1 $QEMU_CFLAGS"
>> - LIBS="-lwinmm -lws2_32 -liberty -liphlpapi $LIBS"
>> + LIBS="-lwinmm -lws2_32 -liphlpapi $LIBS"
>> +cat > $TMPC << EOF
>> +int main(void) { return 0; }
>> +EOF
>> + if compile_prog "" "-liberty" ; then
>> + LIBS="-liberty $LIBS"
>> + fi
>> prefix="c:/Program Files/Qemu"
>> mandir="\${prefix}"
>> datadir="\${prefix}"

See commit 08f3896a072c6d05e36ec3fa4fd303ea550ee38f:

Author: Stefan Weil <weil@mail.berlios.de>
Date:   Fri Feb 4 22:38:47 2011 +0100

     w32: Use additional library libiberty.a

     libiberty.a is part of MinGW and provides useful functions
     like ffs (MinGW) and getopt (MinGW-w64).

     It is needed for w64 compilations and allows simpler code for w32.

     Cc: Anthony Liguori <aliguori@us.ibm.com>
     Signed-off-by: Stefan Weil <weil@mail.berlios.de>
     Signed-off-by: Blue Swirl <blauwirbel@gmail.com>



It looks like newer versions of MinGW-w64 don't have libiberty.a
while older ones (Debian squeeze) provide it. For those versions
which have libiberty.a, it is needed because it includes ffs, strncmp
and several other functions used by QEMU code.

Stefan

  reply	other threads:[~2012-03-10 18:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-10 10:14 [Qemu-devel] [PATCH] w64: Don't redefine lseek, ftruncate Stefan Weil
2012-03-10 10:14 ` [Qemu-devel] [PATCH] configure: Test for libiberty.a (mingw32) Stefan Weil
2012-03-10 16:28   ` Andreas Färber
2012-03-10 18:47     ` Stefan Weil [this message]
2012-03-11 16:10   ` Blue Swirl
2012-03-10 12:11 ` [Qemu-devel] [PATCH] w64: Don't redefine lseek, ftruncate Andreas Färber
2012-03-10 16:17   ` Stefan Weil
2012-03-11 16:09 ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5BA1B8.80606@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=afaerber@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).