From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S6kHG-0004ra-2V
	for qemu-devel@nongnu.org; Sun, 11 Mar 2012 11:01:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S6kHE-0005BH-CG
	for qemu-devel@nongnu.org; Sun, 11 Mar 2012 11:01:41 -0400
Received: from mail-we0-f173.google.com ([74.125.82.173]:65092)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S6kHE-0005BC-31
	for qemu-devel@nongnu.org; Sun, 11 Mar 2012 11:01:40 -0400
Received: by werp12 with SMTP id p12so3035596wer.4
	for <qemu-devel@nongnu.org>; Sun, 11 Mar 2012 08:01:38 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F5CBE4F.1040007@redhat.com>
Date: Sun, 11 Mar 2012 16:01:35 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1331430564-32745-1-git-send-email-mjt@msgid.tls.msk.ru>
	<1331430564-32745-7-git-send-email-mjt@msgid.tls.msk.ru>
In-Reply-To: <1331430564-32745-7-git-send-email-mjt@msgid.tls.msk.ru>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2 6/7] cleanup qemu_co_sendv(),
	qemu_co_recvv() and friends
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org

Il 11/03/2012 02:49, Michael Tokarev ha scritto:
> The same as for non-coroutine versions in previous patches:
> rename arguments to be more obvious, change type of arguments
> from int to size_t where appropriate, and use common code for
> send and receive paths (with one extra argument) since these
> are exactly the same.  Use common qemu_sendv_recvv() directly.
> Also constify buf arg of qemu_co_send().
> 
> qemu_co_sendv(), qemu_co_recvv(), and qemu_co_recv() are now
> trivial #define's merely adding one extra arg.  qemu_co_send()
> is an inline function due to `buf' arg de-constification.

Again, I don't see the point in using #defines.  Either leave the
function static, or you can export it but then inlines are preferrable.

> qemu_co_sendv() and qemu_co_recvv() callers are converted to
> different argument order.

Paolo