From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40472)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S72cZ-0007jq-IM
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 06:37:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S72cP-0002zO-U1
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 06:36:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62820)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S72cP-0002z6-Lx
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 06:36:45 -0400
Message-ID: <4F5DD1B8.1040901@redhat.com>
Date: Mon, 12 Mar 2012 12:36:40 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1330893156-26569-1-git-send-email-afaerber@suse.de>
	<1330893156-26569-2-git-send-email-afaerber@suse.de>
	<4F5485F6.9060109@redhat.com> <4F5AAFC6.9040202@suse.de>
In-Reply-To: <4F5AAFC6.9040202@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 1/3] kvmclock: Always register type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, anthony@codemonkey.ws, lcapitulino@redhat.com

On 03/10/2012 03:35 AM, Andreas F=C3=A4rber wrote:
> Am 05.03.2012 10:23, schrieb Avi Kivity:
> > On 03/04/2012 10:32 PM, Andreas F=C3=A4rber wrote:
> >> Currently, the "kvmclock" type is only registered when kvm_enabled().
> >>
> >> This breaks when moving type registration to before command line
> >> parsing (so that QOM types can be used for CPU and machine).
> >>
> >> Since the QOM classes are lazy-initialized anyway and kvmclock_creat=
e()
> >> has another kvm_enabled() check, simply drop the KVM check in
> >> kvmclock_register_types().
> >>
> >> kvm-i8259, kvm-apic and kvm-ioapic do not suffer from such a check.
> >=20
> > Patch looks good.
>
> Ping for series.
>
> Avi, do you want to sign this patch off through uq/master? Or should I
> make the above a Reviewed-by (and remove the Cc:) within this series?
>

Reviewed-by: please.

--=20
error compiling committee.c: too many arguments to function