From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S759v-00051c-VG for qemu-devel@nongnu.org; Mon, 12 Mar 2012 09:19:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S759T-0003xl-Q3 for qemu-devel@nongnu.org; Mon, 12 Mar 2012 09:19:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S759T-0003uS-Gc for qemu-devel@nongnu.org; Mon, 12 Mar 2012 09:19:03 -0400 Message-ID: <4F5DEFCD.2050904@redhat.com> Date: Mon, 12 Mar 2012 13:45:01 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1331409387-18234-1-git-send-email-bos@je-eigen-domein.nl> <4F5DE49D.1050402@redhat.com> <4F5DE791.8020101@je-eigen-domein.nl> In-Reply-To: <4F5DE791.8020101@je-eigen-domein.nl> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ide: Adds "model=s" option, allowing the user to override the default disk model name "QEMU HARDDISK" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Floris Bos / Maxnet Cc: Markus Armbruster , qemu-devel@nongnu.org, Stefan Hajnoczi Am 12.03.2012 13:09, schrieb Floris Bos / Maxnet: > On 03/12/2012 12:57 PM, Kevin Wolf wrote: >> Am 10.03.2012 20:56, schrieb Floris Bos: >>> Some Linux distributions use the /dev/disk/by-id/scsi-SATA_name-of-disk-model_serial addressing scheme >>> when refering to partitions in /etc/fstab and elsewhere. >>> This causes problems when starting a disk image taken from an existing physical server under qemu, >>> because when running under qemu name-of-disk-model is always "QEMU HARDDISK" >>> This patch introduces a model=s option which in combination with the existing serial=s option can be used to >>> fake the disk the operating system was previously on, allowing the OS to boot properly. >>> >>> Cc: kwolf@redhat.com >>> Signed-off-by: Floris Bos >> Oh, and now that I look at the actual patch, do we really want to add >> the model=... option to -drive? I think just the qdev property may be >> enough. When you need to set the option, you would need to use -device, >> but it's not that hard. > > Well, to me it makes sense to put it at the same places "serial" is, as > both options have quite similar functions: faking drive attributes. -drive serial=... is older than -device, this is why it was okay back then and why we still have to maintain it for compatibility. If serial=... was a new patch today, I would probably be asking the same question there. Kevin