From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S76JE-0006a8-JF for qemu-devel@nongnu.org; Mon, 12 Mar 2012 10:33:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S76J6-0003ya-7t for qemu-devel@nongnu.org; Mon, 12 Mar 2012 10:33:12 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:40562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S76J5-0003yM-VN for qemu-devel@nongnu.org; Mon, 12 Mar 2012 10:33:04 -0400 Received: by dadp14 with SMTP id p14so6437856dad.4 for ; Mon, 12 Mar 2012 07:33:01 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4F5E0917.7000001@redhat.com> Date: Mon, 12 Mar 2012 15:32:55 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1331143301-28408-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1331143301-28408-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] decouple VIRTIO_BLK_F_SCSI from SG_IO support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amit.shah@redhat.com, owasserm@redhat.com, qemu-devel@nongnu.org, mst@redhat.com Il 07/03/2012 19:01, Paolo Bonzini ha scritto: > VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse* > SCSI requests, not *execute* them. So it should always be enabled, > and the scsi=on/off property tied to a separate configuration variable > that is not guest visible. > > With this change, Linux has problems understanding failed requests, so > patch 1 works around the Linux bugs. > > Important: because we need to do this to fix a migration compatibility > problem when QEMU might be invoked with an old machine type, we must do > this unconditionally. This more or less assumes that no one ever invoked > QEMU with scsi=off, as it breaks migration from new QEMU, scsi=off to > old QEMU, also scsi=off. However new->old is not supported upstream. > If any downstream cares about new->old migration, they can apply v1 of > the patches instead of this. > > Paolo Bonzini (3): > virtio-blk: report non-zero status when failing SG_IO requests > virtio-blk: define VirtIOBlkConf > virtio-blk: always enable VIRTIO_BLK_F_SCSI > > hw/s390-virtio-bus.c | 10 ++++-- > hw/s390-virtio-bus.h | 4 +- > hw/virtio-blk.c | 77 ++++++++++++++++++++++++------------------------- > hw/virtio-blk.h | 14 +++++---- > hw/virtio-pci.c | 11 ++++--- > hw/virtio-pci.h | 4 +- > hw/virtio.h | 4 +- > 7 files changed, 64 insertions(+), 60 deletions(-) > Ping. Paolo