From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36315)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1S76oe-0003RV-D6
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 11:06:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1S76oW-0003I6-EG
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 11:05:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47841)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1S76oW-0003Hm-69
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 11:05:32 -0400
Message-ID: <4F5E10AE.9010409@redhat.com>
Date: Mon, 12 Mar 2012 16:05:18 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1331564005-31070-1-git-send-email-zwu.kernel@gmail.com>
In-Reply-To: <1331564005-31070-1-git-send-email-zwu.kernel@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/2] block: add the support to drain
	throttled requests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: zwu.kernel@gmail.com
Cc: kwolf@redhat.com, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

Il 12/03/2012 15:53, zwu.kernel@gmail.com ha scritto:
> -    qemu_aio_flush();
> +    QTAILQ_FOREACH(bs, &bdrv_states, list) {
> +        do {
> +            qemu_co_queue_restart_all(&bs->throttled_reqs);
> +            qemu_aio_flush();
> +        } while (!qemu_co_queue_empty(&bs->throttled_reqs));
> +    }

Even this is not enough.  Block device 2 could start a throttled request
on block device 1.  I'm sending a related series, I'll include yours in
mine.

Paolo