qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format
Date: Mon, 12 Mar 2012 09:42:44 -0600	[thread overview]
Message-ID: <4F5E1974.3010906@redhat.com> (raw)
In-Reply-To: <1331557893-30806-1-git-send-email-marcandre.lureau@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

On 03/12/2012 07:11 AM, Marc-André Lureau wrote:
> Hi,
> 
> The current screendump command can only save to disk very large PPM files.
> 
> The following patches add support for screendump in a UNIX socket, following the syntax used for migration URI: "unix:/path/to/socket". 

Libvirt would also benefit from screendump to fd:name (where name refers
to an fd passed via getfd).

> 
> The last 3 patches add support for dumping in PNG format. This can reduce the size of the image by a great factor (x10 is not unusual), and is also a more convenient format than PPM. Currently, it dumps in PNG by checking if the path ends with ".png", we may want to have a seperate option for that instead,

You will need a separate option for this, if you add fd:name parsing,
since name won't necessarily have a .png suffix (I guess libvirt could
use getfd to name an fd with a .png suffix, but that seems weird).

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]

  parent reply	other threads:[~2012-03-12 15:43 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12 13:11 [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format Marc-André Lureau
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 1/7] ppm_save: use QEMUFile Marc-André Lureau
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 2/7] Allow a qemu_fopen_socket() to be opened for writing Marc-André Lureau
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 3/7] Close socket when closing QEMUFile Marc-André Lureau
2012-03-13  6:09   ` Igor Mitsyanko
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 4/7] Allow saving screendump to a UNIX socket Marc-André Lureau
2012-03-12 17:07   ` Daniel P. Berrange
2012-03-13  8:15   ` Gerd Hoffmann
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 5/7] configure: split PNG support from vnc_png feature Marc-André Lureau
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 6/7] Isolate color conversion from PPM handling Marc-André Lureau
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 7/7] Add PNG screendump Marc-André Lureau
2012-03-12 17:05   ` Daniel P. Berrange
2012-03-12 15:42 ` Eric Blake [this message]
2012-03-12 19:29   ` [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format Marc-André Lureau
2012-03-12 17:10 ` Daniel P. Berrange
2012-03-12 18:06 ` Stefan Hajnoczi
2012-03-12 19:27   ` Marc-André Lureau
2012-03-13 10:59     ` Stefan Hajnoczi
2012-03-13 11:14       ` Marc-André Lureau
2012-03-13 11:17         ` Stefan Hajnoczi
2012-03-13 13:17           ` Gerd Hoffmann
2012-03-14  9:42             ` Stefan Hajnoczi
2012-03-14  9:51               ` Gerd Hoffmann
2012-03-14 10:01                 ` Stefan Hajnoczi
2012-03-14 13:13                   ` Luiz Capitulino
2012-03-14 13:19                     ` Alon Levy
2012-03-14 13:28                       ` Eric Blake
2012-03-14 13:36                         ` Luiz Capitulino
2012-03-14 11:42               ` Kevin Wolf
2012-03-14 13:14                 ` Luiz Capitulino
2012-03-12 18:53 ` Anthony Liguori
2012-03-12 18:56   ` Marc-André Lureau
2012-03-12 18:57     ` Anthony Liguori
2012-03-12 21:22       ` Michael Roth
2012-03-13 10:12         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5E1974.3010906@redhat.com \
    --to=eblake@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).