From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50988)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S77o7-00039A-0i
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 12:09:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S77ns-0004PH-RK
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 12:09:10 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:53481)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S77ns-0004Mv-Ke
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 12:08:56 -0400
Received: by ghrr14 with SMTP id r14so3203660ghr.4
	for <qemu-devel@nongnu.org>; Mon, 12 Mar 2012 09:08:55 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F5E1F90.9080004@redhat.com>
Date: Mon, 12 Mar 2012 17:08:48 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1331553783-13761-1-git-send-email-bos@je-eigen-domein.nl>
	<m3pqcilyko.fsf@blackfin.pond.sub.org>
	<4F5E15DD.3060108@je-eigen-domein.nl>
In-Reply-To: <4F5E15DD.3060108@je-eigen-domein.nl>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] ide: Adds "model=s" option,
 allowing the user to override the default disk model name "QEMU
 HARDDISK"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Floris Bos / Maxnet <bos@je-eigen-domein.nl>
Cc: qemu-devel@nongnu.org, Dmitry Fleytman <dmitry.fleytman@ravellosystems.com>

Il 12/03/2012 16:27, Floris Bos / Maxnet ha scritto:
>>
>>
>> 1. IDE only, scsi-disk is missing.
> 
> Correct.
> IDE support is easy.
> 
> Adding SCSI support is more complicated, because "model" and "serial"
> are not the only factors that can make up a  /dev/disk/by-id link
> Could be a combination of 3 fields: vendor, model and serial.
> But could also be based on another unique ascii or binary identifier
> provided by the drive through Vital Product Data page 83h.

I am going to add customization of VPD page 83h soonish (though only
limited to another ASCII identifier), and Dmitry Fleytman told me
offlist that he's going to add vendor/model support too.

That said, I agree with the other comments from Markus.

Paolo