qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] block: push recursive flushing up from drivers
Date: Mon, 12 Mar 2012 17:22:29 +0100	[thread overview]
Message-ID: <4F5E22C5.8020900@redhat.com> (raw)
In-Reply-To: <4F5E22C9.1000701@redhat.com>

Il 12/03/2012 17:22, Kevin Wolf ha scritto:
>> > In most cases, bdrv_co_flush_to_disk just needs to flush the underlying
>> > file for protocols.  Do this implicitly in the block layer.
>> > 
>> > The backing file is also flushed, because it may still be open read-write
>> > in the case of live snapshots.
> Is this an independent change? I'm also not convinced that it's the
> right thing to do because even though it is still opened read-write, we
> don't write to it any more. Once bdrv_reopen() is ready, we'll want to
> change it to read-only after taking the snapshot.

Ok, I'll remove it.

Paolo

      reply	other threads:[~2012-03-12 16:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12 16:01 [Qemu-devel] [PATCH] block: push recursive flushing up from drivers Paolo Bonzini
2012-03-12 16:22 ` Kevin Wolf
2012-03-12 16:22   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5E22C5.8020900@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).