From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S781U-0007k0-BH for qemu-devel@nongnu.org; Mon, 12 Mar 2012 12:23:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7815-0007xW-MH for qemu-devel@nongnu.org; Mon, 12 Mar 2012 12:22:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7815-0007xF-E6 for qemu-devel@nongnu.org; Mon, 12 Mar 2012 12:22:35 -0400 Message-ID: <4F5E22C5.8020900@redhat.com> Date: Mon, 12 Mar 2012 17:22:29 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1331568108-13188-1-git-send-email-pbonzini@redhat.com> <4F5E22C9.1000701@redhat.com> In-Reply-To: <4F5E22C9.1000701@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: push recursive flushing up from drivers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Il 12/03/2012 17:22, Kevin Wolf ha scritto: >> > In most cases, bdrv_co_flush_to_disk just needs to flush the underlying >> > file for protocols. Do this implicitly in the block layer. >> > >> > The backing file is also flushed, because it may still be open read-write >> > in the case of live snapshots. > Is this an independent change? I'm also not convinced that it's the > right thing to do because even though it is still opened read-write, we > don't write to it any more. Once bdrv_reopen() is ready, we'll want to > change it to read-only after taking the snapshot. Ok, I'll remove it. Paolo