From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38734)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.langsdorf@calxeda.com>) id 1S78y7-0001mg-VE
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 13:23:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.langsdorf@calxeda.com>) id 1S78xs-0004sy-Fp
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 13:23:35 -0400
Received: from smtp141.dfw.emailsrvr.com ([67.192.241.141]:52274)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.langsdorf@calxeda.com>) id 1S78xs-0004sh-Ad
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 13:23:20 -0400
Message-ID: <4F5E3122.1060206@calxeda.com>
Date: Mon, 12 Mar 2012 12:23:46 -0500
From: Mark Langsdorf <mark.langsdorf@calxeda.com>
MIME-Version: 1.0
References: <1331225951-31306-1-git-send-email-mark.langsdorf@calxeda.com>
	<1331570005-18492-1-git-send-email-mark.langsdorf@calxeda.com>
	<4F5E288B.1050905@suse.de>
	<CAFEAcA_jN=Ykh9H7vBC5Kybt_PtSmY-WtgqeVg1F11kZ83HLpg@mail.gmail.com>
In-Reply-To: <CAFEAcA_jN=Ykh9H7vBC5Kybt_PtSmY-WtgqeVg1F11kZ83HLpg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3] use an uint64_t for the max_sz
	parameter in load_image_targphys
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "agraf@suse.de" <agraf@suse.de>, "armbru@redhat.com" <armbru@redhat.com>, "eblake@redhat.com" <eblake@redhat.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>

On 03/12/2012 12:13 PM, Peter Maydell wrote:
> On 12 March 2012 16:47, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> A very non-intrusive solution for allowing large theoretical limits.
>> I've skimmed through the callers and it looks fine.
>>
>> Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>
>>
>> Independently David's off_t patch or a variation thereof would still b=
e
>> needed to make use of the enlarged limit, wouldn't it? Image sizes
>> remain int here.
>=20
> Yes. Also the arm_boot.c code is still passing things around in
> int variables, which should be updated to use uint64_t. (The
> arm_boot device tree code needs updating too, to check whether
> the dtb is using 32 bit or 64 bit cell sizes for its RAM size).
> I'm happy to put together a patch to do this at some point if
> Mark doesn't already have one lined up.

I don't have one lined up for that.

--Mark Langsdorf
Calxeda, Inc.