From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7B9z-0008Hs-NC for qemu-devel@nongnu.org; Mon, 12 Mar 2012 15:44:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7B9x-0004aR-WB for qemu-devel@nongnu.org; Mon, 12 Mar 2012 15:43:59 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:63823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7B9x-0004aE-QM for qemu-devel@nongnu.org; Mon, 12 Mar 2012 15:43:57 -0400 Received: by dadp14 with SMTP id p14so6829023dad.4 for ; Mon, 12 Mar 2012 12:43:56 -0700 (PDT) Message-ID: <4F5E51F8.4030309@codemonkey.ws> Date: Mon, 12 Mar 2012 14:43:52 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <87wr6pwvas.fsf@ginnungagap.bsc.es> <4F5E3C1A.5060103@codemonkey.ws> <87zkblr4m5.fsf@ginnungagap.bsc.es> In-Reply-To: <87zkblr4m5.fsf@ginnungagap.bsc.es> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] We need more reviewers/maintainers!! List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Llu=EDs_Vilanova?= Cc: qemu-devel@nongnu.org, Stefano Stabellini On 03/12/2012 02:39 PM, Lluís Vilanova wrote: > Anthony Liguori writes: > [...] >>> My understanding until now was that both Acked-by and Reviewed-by were tags >>> reserved to people with privileges to write into the repository. > >> That's interesting feedback. These are all documented throughly in Linux's >> SubmittingPatches (which I think ours refers to). > > It does indeed link to that file, but when referring to the "Signed-off-by" tag. > > Maybe adding a line there pointing the user to look for a description of > relevant tags in sections 12 to 14 might help. > > Still, it's not completely clear to me the difference between review and ack. Reviewed-by == you have reviewed a patch in detail and were not able to spot any issues with it. But you are not claiming that you've tested the patch. Acked-by == weaker than Reviewed-by and usually reserved for submaintainers or for someone who needs to approve a change. It's an indication that you agree with the principle of the patch but haven't reviewed it thoroughly. > BTW, the links in the wiki pointing to CODING_STYLE and HACKING are broken, but > it seems that I forgot my user name or it has been deleted, and I can no longer > add an account. Send me a private note with your desired username. Regards, Anthony Liguori > > > Lluis >