From: Gerd Hoffmann <kraxel@redhat.com>
To: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events
Date: Tue, 13 Mar 2012 07:42:17 +0100 [thread overview]
Message-ID: <4F5EEC49.2080200@redhat.com> (raw)
In-Reply-To: <20120312155002.GV6256@garlic>
On 03/12/12 16:50, Alon Levy wrote:
> On Mon, Mar 12, 2012 at 01:43:11PM +0200, Alon Levy wrote:
>> On Mon, Mar 12, 2012 at 11:20:55AM +0100, Gerd Hoffmann wrote:
>>> On 03/11/12 20:26, Alon Levy wrote:
>>>> dprint is still used for qxl_init_common one time prints.
>>>
>>> I think we shouldn't simply convert the dprintf's into trace-points.
>>>
>>> We should look at each dprintf and check whenever it makes sense at all,
>>> whenever it makes sense at that place before converting it over to a
>>> tracepoint.
>
> I'll also add qxl_spice_* trace points for the next patch. Does that
> sound excessive? you could just trace the qxl_io_write to get the io
> itself, or trace just qxl_spice_* to get the qxl<->spice interface, or
> both (qxl_*).
Makes sense to place trace points systematically like that.
cheers,
Gerd
next prev parent reply other threads:[~2012-03-13 6:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 16:39 [Qemu-devel] [PATCH 0/4] fix qxl screendump using monitor_suspend Alon Levy
2012-03-11 16:39 ` [Qemu-devel] [PATCH 1/4] qxl: switch qxl.c to trace-events Alon Levy
2012-03-11 16:39 ` [Qemu-devel] [PATCH 2/4] qxl/qxl_render.c: add trace events Alon Levy
2012-03-11 16:39 ` [Qemu-devel] [PATCH 3/4] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump Alon Levy
2012-03-11 16:39 ` [Qemu-devel] [PATCH 4/4] qxl-render: call ppm_save on bh Alon Levy
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 0/5] fix qxl screendump using monitor_suspend Alon Levy
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events Alon Levy
2012-03-12 10:20 ` Gerd Hoffmann
2012-03-12 11:43 ` Alon Levy
2012-03-12 15:50 ` Alon Levy
2012-03-13 6:42 ` Gerd Hoffmann [this message]
2012-03-13 9:35 ` Alon Levy
2012-03-13 9:47 ` Gerd Hoffmann
2012-03-13 10:18 ` Alon Levy
2012-03-13 10:26 ` Alon Levy
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 2/5] qxl/qxl_render.c: add trace events Alon Levy
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 3/5] qxl-render: call ppm_save on bh Alon Levy
2012-03-13 13:22 ` Luiz Capitulino
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump Alon Levy
2012-03-13 13:35 ` Luiz Capitulino
2012-03-13 14:46 ` Alon Levy
2012-03-13 15:59 ` Luiz Capitulino
2012-03-13 17:35 ` Alon Levy
2012-03-13 18:07 ` Luiz Capitulino
2012-03-14 8:25 ` Gerd Hoffmann
2012-03-14 8:32 ` Alon Levy
2012-03-14 8:14 ` Gerd Hoffmann
2012-03-14 8:37 ` Daniel P. Berrange
2012-03-14 12:32 ` Luiz Capitulino
2012-03-14 13:14 ` Alon Levy
2012-03-14 13:17 ` Daniel P. Berrange
2012-03-14 13:18 ` Luiz Capitulino
2012-03-14 13:43 ` Alon Levy
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 5/5] qxl: screendump: use provided Monitor Alon Levy
2012-03-11 19:33 ` [Qemu-devel] [PATCH 0/4] fix qxl screendump using monitor_suspend Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5EEC49.2080200@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).