From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46686)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S7LR9-000797-3A
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 02:42:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S7LR7-0004Nr-G7
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 02:42:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8011)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S7LR7-0004NX-7p
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 02:42:21 -0400
Message-ID: <4F5EEC49.2080200@redhat.com>
Date: Tue, 13 Mar 2012 07:42:17 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1331483977-18910-1-git-send-email-alevy@redhat.com>
	<1331494004-26177-1-git-send-email-alevy@redhat.com>
	<1331494004-26177-2-git-send-email-alevy@redhat.com>
	<4F5DCE07.5040407@redhat.com> <20120312114311.GH6256@garlic>
	<20120312155002.GV6256@garlic>
In-Reply-To: <20120312155002.GV6256@garlic>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com

On 03/12/12 16:50, Alon Levy wrote:
> On Mon, Mar 12, 2012 at 01:43:11PM +0200, Alon Levy wrote:
>> On Mon, Mar 12, 2012 at 11:20:55AM +0100, Gerd Hoffmann wrote:
>>> On 03/11/12 20:26, Alon Levy wrote:
>>>> dprint is still used for qxl_init_common one time prints.
>>>
>>> I think we shouldn't simply convert the dprintf's into trace-points.
>>>
>>> We should look at each dprintf and check whenever it makes sense at all,
>>> whenever it makes sense at that place before converting it over to a
>>> tracepoint.
> 
> I'll also add qxl_spice_* trace points for the next patch. Does that
> sound excessive? you could just trace the qxl_io_write to get the io
> itself, or trace just qxl_spice_* to get the qxl<->spice interface, or
> both (qxl_*).

Makes sense to place trace points systematically like that.

cheers,
  Gerd