From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7MtV-0004Nv-3T for qemu-devel@nongnu.org; Tue, 13 Mar 2012 04:15:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7Mt1-00069G-WB for qemu-devel@nongnu.org; Tue, 13 Mar 2012 04:15:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7Mt1-00068l-Og for qemu-devel@nongnu.org; Tue, 13 Mar 2012 04:15:15 -0400 Message-ID: <4F5F020D.2040409@redhat.com> Date: Tue, 13 Mar 2012 09:15:09 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1331557893-30806-1-git-send-email-marcandre.lureau@redhat.com> <1331557893-30806-5-git-send-email-marcandre.lureau@redhat.com> In-Reply-To: <1331557893-30806-5-git-send-email-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH/RFC 4/7] Allow saving screendump to a UNIX socket List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= Cc: =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , qemu-devel@nongnu.org Hi, > By using the 'unix:' prefix notation, similar to the migration uri, we > can now dump to a UNIX socket. IO is still sync > hw/vga.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++- This calls for a screendump.c IMHO. vga.c is big enougth already and screendump hasn't much to do with vga, it is a generic service which should work with every qemu-emulated display adapter (and it actually does, ppm_save takes a hardware-independant displaysurface and is called from a few non-vga places). cheers, Gerd