From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7OKs-0005uP-Jt for qemu-devel@nongnu.org; Tue, 13 Mar 2012 05:48:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7OKm-000117-DS for qemu-devel@nongnu.org; Tue, 13 Mar 2012 05:48:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7OKm-00010y-5p for qemu-devel@nongnu.org; Tue, 13 Mar 2012 05:48:00 -0400 Message-ID: <4F5F17CA.4030304@redhat.com> Date: Tue, 13 Mar 2012 10:47:54 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1331483977-18910-1-git-send-email-alevy@redhat.com> <1331494004-26177-1-git-send-email-alevy@redhat.com> <1331494004-26177-2-git-send-email-alevy@redhat.com> <4F5DCE07.5040407@redhat.com> <20120312114311.GH6256@garlic> <20120312155002.GV6256@garlic> <4F5EEC49.2080200@redhat.com> <20120313093551.GF27659@garlic.redhat.com> In-Reply-To: <20120313093551.GF27659@garlic.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com Hi, > What about having the frequent (read: too frequent to use stderr to dump > them since they clutter the screen, unless you 'stop' before each > monitor command) have a postfix "_freq"? This is a stopgap, but helpful > one, you can then do: > trace-event qxl* on > trace-event qxl*freq off > > Instead of remembering / having conveniently ready a longer list: > trace-event qxl* on > trace-event qxl_interface_get_command_enter off > trace-event qxl_interface_release_resource off > trace-event qxl_interface_get_command_ret off > trace-event qxl_push_free_res off Hmm, I'd suggest to just try find better names. These all are about ring management (well, free_res is a bit special, but still ...), so maybe: qxl_ring_{command,cursor}_check (check whenever stuff is in there) qxl_ring_{command,cursor}_get (take item out of the ring) qxl_ring_res_put (stuff item into the ring) Then you can match them likewise easy with "qxl_ring_*", but you have descriptive names without the IMHO ugly _freq suffix. cheers, Gerd