From: Gerd Hoffmann <kraxel@redhat.com>
To: malc <av1474@comtv.ru>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
dlaor@redhat.com, dnb@redhat.com,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)
Date: Tue, 13 Mar 2012 11:19:28 +0100 [thread overview]
Message-ID: <4F5F1F30.2020101@redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1203130101170.5760@linmac>
Hi,
>> I do to, except when they fix broken behaviour. More seriously, do you
>> have other concerns with the mixemu code?
>
> Sure - it adds overhead.
The point of this patchset is to kill the overhead if possible, i.e. try
to pass down the volume the guest asked for all the way down to the
hosts's audio hardware.
This patchset starts with spice and pulse, adding support to other audio
backends (oss, alsa, windows, ...) shouldn't be hard, mixemu shouldn't
be used in the common case then.
I think we should remove the mixemu configure option. It makes code
bitrot. Patch #4 proves that. If you want to keep it because of the
overhead or other reasons I'd suggest to make it a runtime option.
cheers,
Gerd
next prev parent reply other threads:[~2012-03-13 10:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 18:50 [Qemu-devel] [PATCH 00/11] apply volume on client side (v3) Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 01/11] audio: add VOICE_VOLUME ctl Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 02/11] audio: don't apply volume effect if backend has VOICE_VOLUME_CAP Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX Marc-André Lureau
2012-03-12 20:03 ` malc
2012-03-12 20:25 ` Marc-André Lureau
2012-03-12 20:29 ` malc
2012-03-12 20:50 ` Marc-André Lureau
2012-03-12 21:00 ` malc
2012-03-12 21:07 ` Marc-André Lureau
2012-03-12 21:11 ` malc
2012-03-12 21:28 ` Marc-André Lureau
2012-03-12 21:42 ` malc
2012-03-12 21:46 ` Marc-André Lureau
2012-03-12 22:52 ` malc
2012-03-12 23:09 ` Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 04/11] hw/ac97: remove USE_MIXER code Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 05/11] hw/ac97: the volume mask is not only 0x1f Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 06/11] hw/ac97: add support for volume control Marc-André Lureau
2012-03-12 19:42 ` malc
2012-03-12 18:50 ` [Qemu-devel] [PATCH 07/11] audio/spice: " Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 08/11] Do not use pa_simple PulseAudio API Marc-André Lureau
2012-03-12 20:05 ` malc
2012-03-12 18:50 ` [Qemu-devel] [PATCH 09/11] configure: pa_simple is not needed anymore Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 10/11] Allow controlling volume with PulseAudio backend Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 11/11] Make mixemu mandatory Marc-André Lureau
2012-03-12 19:44 ` [Qemu-devel] [PATCH 00/11] apply volume on client side (v3) malc
2012-03-12 20:35 ` Marc-André Lureau
2012-03-12 20:51 ` malc
2012-03-12 20:59 ` Marc-André Lureau
2012-03-12 21:02 ` malc
2012-03-13 10:19 ` Gerd Hoffmann [this message]
2012-03-13 10:33 ` Kevin Wolf
2012-03-13 10:34 ` Gerd Hoffmann
2012-03-13 11:02 ` Marc-André Lureau
2012-03-13 12:09 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5F1F30.2020101@redhat.com \
--to=kraxel@redhat.com \
--cc=av1474@comtv.ru \
--cc=dlaor@redhat.com \
--cc=dnb@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).