From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7Opm-0007xk-02 for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:20:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7OpN-00087J-Ff for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:20:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7OpN-00086v-7d for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:19:37 -0400 Message-ID: <4F5F1F30.2020101@redhat.com> Date: Tue, 13 Mar 2012 11:19:28 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1331578211-18232-1-git-send-email-marcandre.lureau@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , dlaor@redhat.com, dnb@redhat.com, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , qemu-devel@nongnu.org Hi, >> I do to, except when they fix broken behaviour. More seriously, do you >> have other concerns with the mixemu code? > > Sure - it adds overhead. The point of this patchset is to kill the overhead if possible, i.e. try to pass down the volume the guest asked for all the way down to the hosts's audio hardware. This patchset starts with spice and pulse, adding support to other audio backends (oss, alsa, windows, ...) shouldn't be hard, mixemu shouldn't be used in the common case then. I think we should remove the mixemu configure option. It makes code bitrot. Patch #4 proves that. If you want to keep it because of the overhead or other reasons I'd suggest to make it a runtime option. cheers, Gerd