Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

[Gerd Hoffmann <kraxel@redhat.com>]

On 03/13/12 11:33, Kevin Wolf wrote:
> Am 13.03.2012 11:19, schrieb Gerd Hoffmann:
>>   Hi,
>>
>>>> I do to, except when they fix broken behaviour. More seriously, do you
>>>> have other concerns with the mixemu code?
>>>
>>> Sure - it adds overhead.
>>
>> The point of this patchset is to kill the overhead if possible, i.e. try
>> to pass down the volume the guest asked for all the way down to the
>> hosts's audio hardware.
>>
>> This patchset starts with spice and pulse, adding support to other audio
>> backends (oss, alsa, windows, ...) shouldn't be hard, mixemu shouldn't
>> be used in the common case then.
> 
> Then the default should probably to use it at least if the backend
> support passing it through? Leaving it broken by default wouldn't be
> very nice.

Agree.  I would make the mixemu runtime switch have an effect only in
case the audio backend doesn't support volume, so the user can pick
between non-working volume control + zero overhead and working volume
control at the price of mixemu overhead then.

cheers,
  Gerd