From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51829)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S7P3y-0004vu-An
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:34:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S7P3s-0002qh-5u
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:34:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4490)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S7P3r-0002qR-RU
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:34:36 -0400
Message-ID: <4F5F22B2.3070002@redhat.com>
Date: Tue, 13 Mar 2012 11:34:26 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1331578211-18232-1-git-send-email-marcandre.lureau@redhat.com>
	<alpine.LNX.2.00.1203122342500.4669@linmac>
	<CAJ+F1C+-_nMwv8XjZNwARMncH-xcqdu5101Gk05it1V8GTb5xw@mail.gmail.com>
	<alpine.LNX.2.00.1203130050110.5556@linmac>
	<CAJ+F1C+WVLEXSpUW+6rGPYjO4Qn3AL=M2ujHpnw9Z7tc7HJxLA@mail.gmail.com>
	<alpine.LNX.2.00.1203130101170.5760@linmac>
	<4F5F1F30.2020101@redhat.com> <4F5F227E.2030506@redhat.com>
In-Reply-To: <4F5F227E.2030506@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: dnb@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= <marcandre.lureau@gmail.com>, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= <marcandre.lureau@redhat.com>

On 03/13/12 11:33, Kevin Wolf wrote:
> Am 13.03.2012 11:19, schrieb Gerd Hoffmann:
>>   Hi,
>>
>>>> I do to, except when they fix broken behaviour. More seriously, do you
>>>> have other concerns with the mixemu code?
>>>
>>> Sure - it adds overhead.
>>
>> The point of this patchset is to kill the overhead if possible, i.e. try
>> to pass down the volume the guest asked for all the way down to the
>> hosts's audio hardware.
>>
>> This patchset starts with spice and pulse, adding support to other audio
>> backends (oss, alsa, windows, ...) shouldn't be hard, mixemu shouldn't
>> be used in the common case then.
> 
> Then the default should probably to use it at least if the backend
> support passing it through? Leaving it broken by default wouldn't be
> very nice.

Agree.  I would make the mixemu runtime switch have an effect only in
case the audio backend doesn't support volume, so the user can pick
between non-working volume control + zero overhead and working volume
control at the price of mixemu overhead then.

cheers,
  Gerd